-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Build trtllm with multi-stage #331
Open
ko3n1g
wants to merge
48
commits into
main
Choose a base branch
from
ko3n1g/build/multistage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+118
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ko3n1g
added
Run CICD
Set + un-set to retrigger
and removed
Run CICD
Set + un-set to retrigger
labels
Oct 1, 2024
ko3n1g
added
Run CICD
Set + un-set to retrigger
and removed
CI
Run CICD
Set + un-set to retrigger
labels
Oct 1, 2024
ko3n1g
added
Run CICD
Set + un-set to retrigger
and removed
Run CICD
Set + un-set to retrigger
labels
Oct 1, 2024
ko3n1g
force-pushed
the
ko3n1g/build/multistage
branch
from
October 1, 2024 15:23
504d902
to
e5e664b
Compare
ko3n1g
added
Run CICD
Set + un-set to retrigger
and removed
Run CICD
Set + un-set to retrigger
labels
Oct 1, 2024
ko3n1g
force-pushed
the
ko3n1g/build/multistage
branch
from
October 1, 2024 15:25
a83877d
to
204e31a
Compare
ko3n1g
added
Run CICD
Set + un-set to retrigger
and removed
Run CICD
Set + un-set to retrigger
labels
Oct 1, 2024
ko3n1g
force-pushed
the
ko3n1g/build/multistage
branch
from
October 1, 2024 15:26
3b0e5e8
to
018a037
Compare
ko3n1g
added
Run CICD
Set + un-set to retrigger
and removed
Run CICD
Set + un-set to retrigger
labels
Oct 9, 2024
terrykong
reviewed
Oct 9, 2024
ko3n1g
added
Run CICD
Set + un-set to retrigger
and removed
Run CICD
Set + un-set to retrigger
labels
Oct 9, 2024
ko3n1g
force-pushed
the
ko3n1g/build/multistage
branch
from
October 9, 2024 20:26
50e766a
to
f10469b
Compare
ko3n1g
added
Run CICD
Set + un-set to retrigger
and removed
Run CICD
Set + un-set to retrigger
labels
Oct 9, 2024
ko3n1g
added
Run CICD
Set + un-set to retrigger
and removed
Run CICD
Set + un-set to retrigger
labels
Oct 9, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
ko3n1g
added
Run CICD
Set + un-set to retrigger
and removed
Run CICD
Set + un-set to retrigger
labels
Oct 9, 2024
ko3n1g
added
Run CICD
Set + un-set to retrigger
and removed
Run CICD
Set + un-set to retrigger
labels
Oct 9, 2024
ko3n1g
added
Run CICD
Set + un-set to retrigger
and removed
Run CICD
Set + un-set to retrigger
labels
Oct 9, 2024
ko3n1g
added
Run CICD
Set + un-set to retrigger
and removed
Run CICD
Set + un-set to retrigger
labels
Oct 9, 2024
terrykong
reviewed
Oct 9, 2024
FROM ${BASE_IMAGE} AS final | ||
WORKDIR /opt | ||
# needed in case git complains that it can't detect a valid email, this email is fake but works | ||
RUN git config --global user.email "worker@nvidia.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think since we're fixing things, we should probably unset this at the very end so that folks don't get surprised their committing code as worker@nvidia.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Changelog
Usage
# Add a code snippet demonstrating how to use this
Before your PR is "Ready for review"
Pre checks:
Checklist when contributing a new algorithm
max_steps=-1
andvalidation
?Additional Information