Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Build trtllm with multi-stage #331

Open
wants to merge 48 commits into
base: main
Choose a base branch
from
Open

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Oct 1, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

@ko3n1g ko3n1g added the Run CICD Set + un-set to retrigger label Oct 1, 2024
@ko3n1g ko3n1g changed the base branch from ko3n1g/ci/unit-tests to main October 1, 2024 11:49
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Oct 1, 2024
@github-actions github-actions bot added the CI label Oct 1, 2024
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger and removed CI Run CICD Set + un-set to retrigger labels Oct 1, 2024
@github-actions github-actions bot added the CI label Oct 1, 2024
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Oct 1, 2024
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Oct 1, 2024
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Oct 1, 2024
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Oct 9, 2024
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Oct 9, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Oct 9, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Oct 9, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Oct 9, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Oct 9, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Oct 9, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Oct 9, 2024
FROM ${BASE_IMAGE} AS final
WORKDIR /opt
# needed in case git complains that it can't detect a valid email, this email is fake but works
RUN git config --global user.email "worker@nvidia.com"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think since we're fixing things, we should probably unset this at the very end so that folks don't get surprised their committing code as worker@nvidia.com

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Run CICD Set + un-set to retrigger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants