Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed string literal error #338

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed string literal error #338

wants to merge 2 commits into from

Conversation

SulRash
Copy link

@SulRash SulRash commented Oct 6, 2024

What does this PR do ?

Fixed the following string literal bug:

Traceback (most recent call last):
  File "/eph/nvme0/azureml/cr/j/5f8208feac9e43b3b90284ba713c821b/exe/wd/train_reward_model.py", line 22, in <module>
    from nemo_aligner.data.nlp.builders import (
  File "/opt/NeMo-Aligner/nemo_aligner/data/nlp/builders.py", line 45, in <module>
    from nemo_aligner.data.nlp.datasets import (
  File "/opt/NeMo-Aligner/nemo_aligner/data/nlp/datasets.py", line 346
    WARNING: It's recommended to preprocess your data in advance to ensure all samples are within self.seq_length.
               ^
SyntaxError: unterminated string literal (detected at line 346)

By changing It's to It is. This fix offers a wider range of compatibility without really modifying any of the logic.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Changelog updated

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests? No necessary tests.
  • Did you add or update any necessary documentation? Make sure to also update the NeMo Framework User Guide which contains the tutorials. No documentation update necessary.

Signed-off-by: Sultan <sultan.m.rashed@gmail.com>
Signed-off-by: Sultan <sultan.m.rashed@gmail.com>
@SulRash
Copy link
Author

SulRash commented Oct 6, 2024

@gshennvm @odelalleau

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant