Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update reward model to support scaled and margin BT #361

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Zhilin123
Copy link
Collaborator

@Zhilin123 Zhilin123 commented Oct 25, 2024

What does this PR do ?

Update reward model to support scaled and margin BT

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

Zhilin123 and others added 2 commits October 25, 2024 14:48
Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>
for more information, see https://pre-commit.ci

Signed-off-by: NeMo-Aligner CI <nemo-aligner-ci@nvidia.com>
@Zhilin123 Zhilin123 changed the title feature update reward model to support scaled, margin and regular bt on top of regression feat: update reward model to support scaled, margin and regular bt on top of regression Oct 25, 2024
@Zhilin123 Zhilin123 changed the title feat: update reward model to support scaled, margin and regular bt on top of regression feat: update reward model to support scaled and margin BT Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant