Pin to spacy<3.8 temporarily to unblock CI #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
ryantwolf
approved these changes
Oct 2, 2024
|
Can you also change it in nightly? |
Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
yyu22
pushed a commit
to yyu22/NeMo-Curator
that referenced
this pull request
Oct 9, 2024
* Pin to spacy<3.8 temporarily to unblock CI Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> * Update pin in rapids nightly dep as well Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> --------- Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> Signed-off-by: Yang Yu <yayu@nvidia.com>
yyu22
pushed a commit
to yyu22/NeMo-Curator
that referenced
this pull request
Oct 10, 2024
* Pin to spacy<3.8 temporarily to unblock CI Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> * Update pin in rapids nightly dep as well Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> --------- Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#273 is exploring removing the
numpy<2pin to see if that remove incompatibility with spacy 3.8 and above. While testing for different extras in ongoing there, this is a temporary fix to unblock CI for other PR's in flight.Usage
N/A
Checklist