[Tutorials] Update the SDG tutorial and expose the inference endpoint #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maghoumi
force-pushed
the
mmaghoumi/sdg-endpoint
branch
from
c48661a
to
077f532
Compare
ryantwolf
requested changes
Oct 21, 2024
There was a problem hiding this comment.
I just have the smallest of nits and we should be good. Also, the DCO check seems to be failing so follow the point 3 in our contributing guide pr guidelines to fix it.
| --api-key YOUR_BUILD.NVIDIA.COM_API_KEY \ | ||
| --synth-gen-endpoint https://api.example.com/v1/chat/completions \ | ||
| --synth-gen-model my-llm-model \ | ||
| --api-key API_KEY_FOR_EXAMPLE.COM \ |
There was a problem hiding this comment.
Nit: Might just be me, but API_KEY_FOR_EXAMPLE.COM makes me think that the API key should end in .com, which it shouldn't. Maybe make it API_KEY_FOR_ENDPOINT instead?
This PR ensures that users can run the PEFT SDG tutorial using arbitrary API endpoints by exposing the URL that is used for synthetic data generation. Signed-off-by: Mehran Maghoumi <Maghoumi@users.noreply.github.com>
Maghoumi
force-pushed
the
mmaghoumi/sdg-endpoint
branch
from
077f532
to
5fd2804
Compare
|
Also fixed the DCO check. Looks like I forgot the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that users can run the PEFT SDG tutorial using arbitrary API endpoints by exposing the URL that is used for synthetic data generation.
Checklist