fix(snap): recover gateway after Docker connection - #2866
Open
elezar wants to merge 2 commits into
Open
Conversation
Signed-off-by: Evan Lezar <elezar@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
🌿 Preview your docs: https://nvidia-preview-pr-2866.docs.buildwithfern.com/openshell |
elezar
marked this pull request as ready for review
August 21, 2026 09:48
elezar
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
August 21, 2026 09:48
drew
reviewed
Aug 21, 2026
Comment on lines
+107
to
+108
| Connecting Docker automatically restarts the gateway so it discovers the newly | ||
| available Docker socket. This restart interrupts active sandbox sessions. |
Signed-off-by: Evan Lezar <elezar@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recover the Snap gateway when the Docker interface becomes available after installation, then make the release canary wait for bounded readiness and retain Snap diagnostics on failure.
Related Issue
Closes #2055.
Changes
Testing
mise run pre-commitpassesChecklist