Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shim version 344 to LogicalPlanShims.scala #11710

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Add shim version 344 to LogicalPlanShims.scala #11710

merged 2 commits into from
Nov 8, 2024

Conversation

SurajAralihalli
Copy link
Collaborator

This PR fixes the CI Build failure by including shim version 344 in LogicalPlanShims.scala

Error: ] /home/runner/work/spark-rapids/spark-rapids/sql-plugin/src/main/spark332db/scala/org/apache/spark/sql/rapids/shims/GpuDataSource.scala:33: object LogicalPlanShims is not a member of package com.nvidia.spark.rapids.shims
Error: ] /home/runner/work/spark-rapids/spark-rapids/sql-plugin/src/main/spark332db/scala/org/apache/spark/sql/rapids/shims/GpuDataSource.scala:88: not found: value LogicalPlanShims

@SurajAralihalli
add 344 to LogicalPlanShims
9a66cf1 
Signed-off-by: Suraj Aralihalli <suraj.ara16@gmail.com>
gerashegalov
gerashegalov previously approved these changes Nov 7, 2024
View reviewed changes
@gerashegalov gerashegalov added bug Something isn't working build Related to CI / CD or cleanly building labels Nov 7, 2024
@gerashegalov
Copy link
Collaborator

build

@SurajAralihalli
Copy link
Collaborator Author

Build

@SurajAralihalli
400 missing supportedExprs.csv
85a6678 
Signed-off-by: Suraj Aralihalli <suraj.ara16@gmail.com>
mythrocks
mythrocks approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick fix, @SurajAralihalli.

@SurajAralihalli
Copy link
Collaborator Author

Build

@pxLi
Copy link
Collaborator

pxLi commented Nov 8, 2024

build

@gerashegalov gerashegalov merged commit d208004 into NVIDIA:branch-24.12 Nov 8, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mythrocks mythrocks mythrocks approved these changes

@gerashegalov gerashegalov gerashegalov left review comments

Assignees

@SurajAralihalli SurajAralihalli

Labels
bug Something isn't working build Related to CI / CD or cleanly building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SurajAralihalli @gerashegalov @pxLi @mythrocks