Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDD Project #1

Merged
merged 14 commits into from
Aug 4, 2023
Merged

TDD Project #1

merged 14 commits into from
Aug 4, 2023

Conversation

Nasirkhan294
Copy link
Owner

@Nasirkhan294 Nasirkhan294 commented Aug 3, 2023

In this milestone we:

  • Tested factorial method using RSpec
  • Tested reverse method using RSpec
  • Tested fizzbuzz method using RSpec

Copy link

@julie-ify julie-ify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Nasirkhan294 and @AliShahSafdari,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

  • The other coding partner only modified the readme file. Kindly note that updating the readme does not count as a contribution to the project. Everyone in the team must commit code.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request does not count into the code reviews limit.

@AliShahSafdari
Copy link
Collaborator

Hi @Nasirkhan294 🙋‍♂️,

✔️ Status: APPROVED 🏆 🎉 🎊
You have done a great job on this project, keep it up 👍 🥇. Your project is complete! There is nothing else to say other than... it's time to merge it: ship it:
Congratulations! 🎉💯🌟

Top highlight 🎯
The Pull Request follows the GitFlow ✅
The PR title and description are professional and descriptive ✅
Linters are working properly ✅

@Nasirkhan294 Nasirkhan294 merged commit e640eb0 into dev Aug 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants