Support for removing Universal Set #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apmoriarty
reviewed
Sep 27, 2024
Comment on lines
96
to
+97
| Assertions.assertEquals(Sets.newHashSet("rowA", "rowB", "rowC"), helper.getAllFields(null)); | ||
| Assertions.assertEquals(Sets.newHashSet("rowA", "rowB", "rowC"), helper.getAllFields(Collections.emptySet())); | ||
| Assertions.assertEquals(Collections.emptySet(), helper.getAllFields(Collections.emptySet())); |
There was a problem hiding this comment.
I thought a null datatype filter and an empty datatype filter both implied "no filter, return everything". Why then the change in behavior?
There was a problem hiding this comment.
The original intent was for a null datatype filter to allow all the things, a populated filter to allow only things contained therein, and an empty filter to allow none of the things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redoing this as it fell thru the cracks many many moons ago - this is in support for NationalSecurityAgency/datawave#1814