Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#106 Formatting fixes #121

Merged
merged 29 commits into from
Oct 16, 2018
Merged

#106 Formatting fixes #121

merged 29 commits into from
Oct 16, 2018

Conversation

derekdkim
Copy link
Contributor

@derekdkim derekdkim commented Oct 13, 2018

Purpose / Goal

A fix for some formatting issues introduced in the previous PR. Sorry about the sloppy job last time.

  • Resized gifs to 800x450 to match all other demo gifs.
  • Changed relative links to make them work.
  • Added a link to features.md on README.md.
  • Added an unordered list for the list of keyboard shortcut documentation in README.md.

Type

  • Bug Fix
  • Refactoring / Technology upgrade
  • New Feature
  • Documentation
  • Other : | Please Specify |

@amitguptagwl
Copy link
Member

amitguptagwl commented Oct 14, 2018

I was wondering if we should move How to use guide to some other page like: GUIDE.md or separate page for each guide. And link the topics on README.md. Eg

How to use

We still should have some featured animations on README.

In this way, we can control the length of README.md.

@derekdkim
Copy link
Contributor Author

@amitguptagwl I personally feel that most of these demo GIFs would be best served in the features tab (right before other features, as most of these are core features of the app), and each heading can be a link for more information. Some of the smaller features could still have a link but no GIF on the README if it's a smaller feature. That way, how to use can be limited to keyboard shortcuts for convenience and link to the guide and tutorial video for more complicated operations.

@derekdkim
Copy link
Contributor Author

I made a mock-up based on your suggestions. I used anchor tags to link to different tabs in guide and it sort of like an all-in-one user guide. I've only added some of the features that I'm familiar with. The order of the content presented in the guide could also be changed around to make it more intuitive if you were to read it from top to bottom. It's currently pushed onto my test branch.

https://github.com/derekdkim/imglab/tree/test

Let me know what you think.

@amitguptagwl
Copy link
Member

It looks perfect. Though some additions are required, they can be added later.

@derekdkim
Copy link
Contributor Author

derekdkim commented Oct 15, 2018

Sorry about the inflated commit counts, I was rebasing my fork and it somehow came into the PR.

@amitguptagwl amitguptagwl merged commit ad04bd6 into NaturalIntelligence:master Oct 16, 2018
@amitguptagwl
Copy link
Member

Thanks for your effort. I believe you've become the 3rd highest contributor to this app.

@derekdkim
Copy link
Contributor Author

Thanks. I didn't actually do much, but I learned a lot from getting exposure to the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants