Add proper handling of EXTENSION tag #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refers to #106
FObermaier
commented
Dec 8, 2022
| /// Adds a parameter to the parameter list | ||
| /// </summary> | ||
| /// <param name="name">The projection parameter name</param> | ||
| /// <param name="value">The value</param> |
There was a problem hiding this comment.
Use Projection.Parameters.Add(new ProjectionParameter(name, value)); and remove this method
| /// <summary> | ||
| /// Adds a parameter to the parameter list | ||
| /// </summary> | ||
| internal void AddParameter(string name, double value) |
There was a problem hiding this comment.
This is not needed to get the solution to compile. The parameters need to be present when the class is constructed anyway, so adding parameters afterwards will not do any good.
FObermaier
commented
Dec 8, 2022
| var projection = new Projection(projectionName, paramList, projectionName, authority, authorityCode, string.Empty, string.Empty, string.Empty); | ||
| return projection; | ||
| } | ||
|
|
||
| private static void ReadParamater(WktStreamTokenizer tokenizer, Projection projection) |
There was a problem hiding this comment.
Typo ReadParameter, argument projection could be of type ICollection<ProjectionParameter>
gktval
pushed a commit
to gktval/ProjNet4GeoAPI
that referenced
this pull request
Dec 9, 2022
Removed the AddParameter method. Added async search methods to the database.
|
Thanks, I remember having problems with AppCompat on that. What you did works. I also made those fixes in #108. There should be a new, third commit to that branch. I am not sure what the conflict is with ProjNet.Test.csproj in that commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kudos to @gktval
refers to #106