WIP: Improve is_internet_accessible() accuracy for Condition blocks #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what's going on with flake8 here but seems unrelated to the change ... ? |
|
Whoops sorry pinged the wrong person ;-; Hi @patricksanders - I don't see too much recent GitHub history for you, but if you have bandwidth would love to get feedback on the approach taken here. Happy to revise w/ feedback, clean it up, etc.! |
|
Hey @tweedge! Sorry for the delay. Let me take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #150.
This is a demo of more accurate conditions handling within statement.py by addition of a new Condition class. This allows us to track the location of each condition entry, and use that to adhere to AWS' evaluation logic. This information is only exposed within the statement.py, and external references to these conditions (ex. whos_allowed() on a Policy object) return ConditionTuple namedtuples as normal, to hopefully avoid breaking downstream projects.
Open to any/all feedback and revision suggestions :)