fix(perf): precompile health regexes, share HTTP client, cut hot-path clones - #676
Open
iamquang95 wants to merge 1 commit into
Open
fix(perf): precompile health regexes, share HTTP client, cut hot-path clones#676iamquang95 wants to merge 1 commit into
iamquang95 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #645
reqwest::Clientper probe meant each RTT measurement included its own TCP/TLS handshake; now one shared client.DutyType::Displayround-tripped throughserde_jsonon every call; now a directas_str().do_recvdeep-cloned aParSignedData(a whole beacon block for proposals) per entry per message; now borrowed..is_empty()check for the existinghas_connection.Behaviour change:
request_rttandrelay_ping_testhad no request timeout; they now use the 10s onebeacon.rs/mev.rsalready applied. Sharing a client also means concurrent probes to one host multiplex over a single HTTP/2 connection — only visible inbeacon_ping_load_test.