Build and publish RPM packages (for EL8/EPEL) #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RHEL8/EPEL brings `importlib-metadata` 0.23 as a package. Since this is a backport of a Python stdlib package (starting with Python 3.9), we can assume its API to be quite stable (furthermore, `gptsum` only uses very basic functionality ofo the library), so let's depend on 0.23 (or higher) without any other bounds (since 'or' version bounds can't be defined in Python, it seems). See: python-poetry/poetry#3840
This is a first step to add RPM building to the project. It adds a new Nox session which doesn't install dependencies as pinned by Poetry (in `poetry.lock`), but instead hard-codes some versions/constraints as found in CentOS 8 and EPEL. Since the original tests code was not compatible with these older versions of packages (e.g., `pytest`), some code changes were required, either based on import names being (un)available, or based on version checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.