Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce pyproject.toml #443

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Introduce pyproject.toml #443

merged 1 commit into from
Feb 6, 2024

Conversation

steven-aerts
Copy link

@steven-aerts steven-aerts commented Feb 6, 2024

Using a more modern setuptools build pipeline, removing warnings in the generated files:

/usr/local/bin/gimme-aws-creds:4: DeprecationWarning:
pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
  __import__('pkg_resources').run_script('gimme-aws-creds==2.7.2', 'gimme-aws-creds')

Description

In this change we introduce a more modern version of packaging this project by using a pyproject.toml.
The changes is the most limited change we could see. Maybe you want to be done more?

Motivation and Context

The docker images and local install (on some setups) generated the above warning.

How Has This Been Tested?

  • build locally and run
  • build docker file see that the warning mentioned above is gone.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Using a more modern setuptools build pipeline, removing warnings in the
generated files:

```
/usr/local/bin/gimme-aws-creds:4: DeprecationWarning:
pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
  __import__('pkg_resources').run_script('gimme-aws-creds==2.7.2', 'gimme-aws-creds')
```
@epierce epierce merged commit b6373f6 into Nike-Inc:master Feb 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants