Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep original force_classic value during profile inheritance #464

Merged
merged 1 commit into from
May 9, 2024

Conversation

noamcohen97
Copy link
Contributor

Description

When inheriting a profile stating force_classic = False this value is getting overridden by the default value force_classic = True if the child profile does not explicitly set force_classic = False as well

Related Issue

fixes #463

Motivation and Context

How Has This Been Tested?

Added a test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@epierce
Copy link
Member

epierce commented May 9, 2024

Looks good - Thanks!

@epierce epierce merged commit 76c2257 into Nike-Inc:master May 9, 2024
7 checks passed
@noamcohen97 noamcohen97 deleted the fix-default-force-classic branch May 9, 2024 14:21
@noamcohen97
Copy link
Contributor Author

@epierce When can we expect this to be released?

@epierce
Copy link
Member

epierce commented May 9, 2024

I should be able to cut a new release early next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

force_classic value is overridden by default when using profile inheritance
2 participants