Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mnt cleanup #87

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Mnt cleanup #87

wants to merge 2 commits into from

Conversation

tacaswell
Copy link
Member

No description provided.

@tacaswell
MNT: clean up qt imports
f69c91a 
 - don't force so much in init, let environment take care of more
 - account for some of coming Qt5 changes
@tacaswell
MNT: change draw to draw_idle
4e4ddd4 
This is more efficient and works around a bug where mpl segfaults if
an invisible Qt canvas is drawn.
ericdill
ericdill approved these changes Jan 20, 2017
View reviewed changes
Copy link
Contributor

@ericdill ericdill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to get rid of the hilarious overbuilt architecture in this project while you're cleaning up? Heh.

@mrakitin
Copy link
Member

I think it conflicts with the changes made later in #88. @tacaswell, are you fine with closing this PR without merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericdill ericdill ericdill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tacaswell @mrakitin @ericdill