Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Releasing 2.6.8 #160

Merged
merged 6 commits into from
Sep 12, 2023
Merged

Releasing 2.6.8 #160

merged 6 commits into from
Sep 12, 2023

Commits on Sep 12, 2023

  1. #159 - Problem with Filters = "" 

    This fixes the problem when Filters = "", however, currently it will place filters = [] in the geojson.
Not sure how CRC Will handle a default that does not have any filters in it.
    @Nikolai558
    Nikolai558 committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    135732b View commit details
    Browse the repository at this point in the history

  2. removed fix from comments.

    @Nikolai558
    Nikolai558 committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    044198b View commit details
    Browse the repository at this point in the history

  3. Default Filters Empty Fix 

    When `filters=""` in the defaults, it will then look at the `bcg=##`. As long as bcg has a valid number it will make the filters = bcg.
    @Nikolai558
    Nikolai558 committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    21be5ec View commit details
    Browse the repository at this point in the history

  4. Updated Changelog and Version Number

    @Nikolai558
    Nikolai558 committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    9dc0dbf View commit details
    Browse the repository at this point in the history

  5. #159 - Filters = "" issue 

    I am going to recant my previous statement and will not be placing the filter value based on BCG values.

The reasoning behind this is there might be quite a few facilities where the BCG value is not supose to match the filter value. Also, in vERAM things that do not have a filter at all are not displayed (same thing happens in CRC). If I were to automatically place the bcg into the filter in the geojson, these facilities would have a bunch of things populate on screen that were never there before.

I personally don't know of a valid reason to set filters="" but I do know that some facilities do it.

Therefore, FEB will create the defaults in geojson with filters = [] and a message will be placed in the log so that users can quickly find what default filters dont have any filters in it. Then they can choose weather or not they want to add filters manually in the geojson. This result should be the same in CRC as it is in vERAM. (i.e. no filters = no display)
    @Nikolai558
    Nikolai558 committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    51dfa9d View commit details
    Browse the repository at this point in the history

  6. Update Changelog.

    @Nikolai558
    Nikolai558 committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    b58ebe5 View commit details
    Browse the repository at this point in the history