vagrant: add vagrant-aws plugin #144799
Open
vagrant: add vagrant-aws plugin #144799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
risicle
force-pushed
the
ris-vagrant-aws
branch
from
73883b9
to
1bec56c
Compare
ofborg
bot
added
10.rebuild-darwin: 0
and removed
10.rebuild-darwin: 1
10.rebuild-darwin: 1-10
labels
stale
bot
added
the
2.status: stale
Et7f3
reviewed
Jan 31, 2024
Comment on lines
-91
to
+99
| substitute ${./vagrant-libvirt.json.in} $out/vagrant-plugins/plugins.d/vagrant-libvirt.json \ | ||
| substitute ${./vagrant-plugin.json.in} $out/vagrant-plugins/plugins.d/vagrant-libvirt.json \ | ||
| --subst-var-by pname libvirt \ | ||
| --subst-var-by ruby_version ${ruby.version} \ | ||
| --subst-var-by vagrant_version ${version} | ||
| '' + |
There was a problem hiding this comment.
Can you create a small helper. I consider adding vagrant-sshfs and reuse that code.
Et7f3
reviewed
Jan 31, 2024
Comment on lines
+5
to
+6
| # dependencies of these two plugins conflict | ||
| assert !(withLibvirt && withAws); |
There was a problem hiding this comment.
It is still the case in 2024 and what command did you use to generate the gemset ? Also use throwIf instead of assert
stale
bot
removed
2.status: stale
wegank
added
2.status: stale
stale
bot
removed
the
2.status: stale
wegank
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
tomodachi94
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Got frustrated trying to get the
vagrant-awsplugin working the "normal" way and so created a package for it. Generating thegemset_aws.nixfor it was ugly, let's not go into it. Tried to essentially follow the pattern of thelibvirtplugin. I realize this isn't the most extensible pattern, but it does the job for now.Unfortunately the dependencies of
vagrant-awsconflict with those ofvagrant-libvirtso I've disabled it by default and added an assertion to alert anyone trying to enable both together. I realize this isn't great, but it solves the problem for me.Package was requested in #121161.
Edit(@tomodachi94): Fixes #121161.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)