jetbrains: add support for plugins on darwin

[FabianPonce]

Description of changes

This change fixes up support for installing plugins with JetBrains IDEs on macOS. Presently on master, this falls with the following:

error: attribute 'mainProgram' missing

       at /nix/store/apa072dsj782n2r23his9y40nm8nkkrm-source/pkgs/applications/editors/jetbrains/plugins/default.nix:84:15:

           83|     stdenv.mkDerivation rec {
           84|       pname = meta.mainProgram + "-with-plugins";
             |               ^
           85|       version = ide.version;

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[leona-ya]

Hey! Thanks for the PR. I tested this on aarch64-darwin and it works fine.

I have some remarks about code style / simplifications

[FabianPonce]

Thanks for the feedback, @leona-ya. I've applied those suggestions.

[leona-ya]

One thing that needs to be done, before (from my side) this could be merged: Please squash all commits into one with a commit message like jetbrains: add plugins support for darwin or jetbrains: fix plugin support for darwin.

Also I think the plugin updates (d1fecc3c9d65d55dc81c8aaa217ca9354da084f0, 0af0af96a51c3a444d02bdb198148d62f878fadf and a part of c05db562799477fc45421ce713f3a33b914b9416) shouldn't be included in this PR, as they'll be adressed in #242493 and might cause strange merge conflicts then

[FabianPonce]

Good point, I'd been using this locally while I waited for the original plugins PR to be merged, but that noise isn't necessary in the git changeset. I've squashed this all down to 1 commit for you, let me know how that looks.

[leona-ya]

LGTM now :) As mentioned: tested on aarch64-darwin

[Janik-Haag]

pinging @GenericNerdyUsername for review since they initially wrote the plugin support.

[GenericNerdyUsername]

Why not add meta.mainProgram to darwin builds?

[Janik-Haag]

Just the one question everything else looks good to me.

[Janik-Haag]

I'm converting this to a draft PR (as I was suggested in the nixpkgs dev matrix room) until you start responding to questions and mark finished conversations as resolved.

[wegank]

Merge conflict, please rebase.

[tymscar]

If there any update on this? Seems to still be broken on darwin

[wegank]

Um, I wonder why I closed the PR instead of rebasing it. I'll see what I can do.