darwin.linux-builder: Disable evaluation #268574
Conversation
A remote builder does not need to evaluate anything, so let's trim it down to (eventually) save some space, and make the purpose of the builder clear. Users should evaluate on the host instead.
These won't cause anything to appear in toplevel.
ofborg
bot
added
6.topic: darwin
|
Successfully created backport PR for |
Now that the underlying darwin.linux-builder doesn't [support evaluation](NixOS/nixpkgs#268574) it doesn't make sense to do as much local configuration/testing that requires root.
| environment.extraSetup = '' | ||
| rm --force $out/bin/{nix-instantiate,nix-build,nix-shell,nix-prefetch*,nix} | ||
| ''; |
There was a problem hiding this comment.
My linux-builder has gotten into a bad state and removing these commands makes it very hard to debug the situation
@roberth I wonder if it's better to revert this section
There was a problem hiding this comment.
Which commands do you need to run?
Would an opt-in option be sufficient for your purposes? Something like:
| environment.extraSetup = '' | |
| rm --force $out/bin/{nix-instantiate,nix-build,nix-shell,nix-prefetch*,nix} | |
| ''; | |
| environment.extraSetup = mkIf (!cfg.nix.evaluator.enable) '' | |
| rm --force $out/bin/{nix-instantiate,nix-build,nix-shell,nix-prefetch*,nix} | |
| ''; |
Currently it's meant to simulate a store-only nix, so there's little benefit to this code as is, except manage expectations when we can reduce the linux builder's closure by only incorporating a store-only build of nix.
There was a problem hiding this comment.
I want to run something like nix build --rebuild so ideally the nix command
If I'm understanding correctly, the default would be to include the nix command, which would be my preference as otherwise if your linux-builder gets in a bad state, it might be quite annoying/hard to bootstrap another one rather than be able to potentially fix it
There was a problem hiding this comment.
it might be quite annoying/hard to bootstrap another
I thought it was basically fully automated, except for clearing it.
Anyway, not being able to debug it properly is annoying, so I'm ok to revert this.
There was a problem hiding this comment.
Even the clearing is automated, too (we set min-free and max-free), but it might still be worth restoring the nix command-line tools for debugging purposes
There was a problem hiding this comment.
I was referring to bootstrapping my own Linux builder locally, but I realize now that if you just comment out any custom configuration (if you're using nix-darwin) and use a cached Linux builder from Nixpkgs that should work fine
I've made a PR here: #347205
Description of changes
A remote builder does not need to evaluate anything, so let's trim it down to (eventually) save some space, and make the purpose of the builder clear.
Users should evaluate on the host instead, if they aren't already.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)