Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draupnir: init at 2.0.0-beta.6 #274052
base: master
Are you sure you want to change the base?
Draupnir: init at 2.0.0-beta.6 #274052
Changes from 4 commits
4fffcb7
1e396ac
bbadc5e
ee8cbf8
4ac0923
4727e58
cbdb027
8c6092f
0ed8bbc
65b7eff
dfc2fb1
e3adb0c
1fac8d3
a13cc66
0c8581d
dbf6ae4
c2a5e05
bd7179d
eb031b1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@teutat3s (sorry for replying this way, github only allows threading in diff comments...)
In reply to your comment about tests
I'm aware that draupnir doesnt officially support pantalaimon (see module warns), thanks for reminding me though, given i'd completely forgotten (and tbh just copied the tests for mjolnir)
I wonder if i should drop the tests with pantalaimon? or well, at least rework it to not use pantal...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
People coming from mjolnir will probably have pantalaimon running. It would be good to notice when things break in obvious ways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pantalaimon/e2ee warning at eval time is enough, is it not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to format this with nixfmt-rfc-style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can nixfmt-rfc-style handle markdown files, or should i extract this nix excerpt into a separate file to process?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extract, format, reinsert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest adding a default here: