go-ethereum: 1.13.5 -> 1.14.3

[gileri]

Description of changes

See https://github.com/ethereum/go-ethereum/releases/.

proxyVendor = true was needed to avoid the following error :

> # github.com/karalabe/hid
> vendor/github.com/karalabe/hid/hid_enabled.go:43:18: fatal error: os/events_posix.h: No such file or directory
>    43 |         #include "os/events_posix.h"
>       |                  ^~~~~~~~~~~~~~~~~~~

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[RaghavSood]

Result of nixpkgs-review pr 311188 run on aarch64-darwin 1

3 packages failed to build:

• go-ethereum
• go-ethereum.clef
• go-ethereum.geth

[RaghavSood]

Looks like ofBorg gets the build error for linux too: https://logs.ofborg.org/?attempt_id=4ada5d40-bb2c-4c07-91b0-6723f62b51cd&key=nixos%2Fnixpkgs.311188

I'm seeing the same hash on aarch64-darwin:

error: hash mismatch in fixed-output derivation '/nix/store/b9a9y8snhpyf42i21sw22yqv6wkqii8d-go-ethereum-1.14.3-go-modules.drv':
         specified: sha256-yD4Z7vbi3D3f9xGxRQjnjbTKljtjRLeIHRAdWjSub6U=
            got:    sha256-ugoRsxzJjPOS5yPhwqXhMPuThvyqCWvZD7PBnrkm0sQ=

Was the hash perhaps updated before proxyVendor was set to true?

[gileri]

Thanks for the report @RaghavSood !
It could have been the case; but that was because I was building against nixos-23.11, and not nipkgs master.

Output tested, PR updated.

[RaghavSood]

Result of nixpkgs-review pr 311188 run on aarch64-darwin 1

3 packages built:

• go-ethereum
• go-ethereum.clef
• go-ethereum.geth

[RaghavSood]

LGTM, will merge after ofborg builds are done

[RaghavSood]

Strange failure for x86_64-darwing, will check that out shortly

[RaghavSood]

@GrahamcOfBorg build go-ethereum

[gileri]

@RaghavSood Looks like the x86_64-darwing build on Ofborg did pass ?

[RaghavSood]

Both aarch64-darwin and x86 are failing: https://logs.ofborg.org/?key=nixos/nixpkgs.311188&attempt_id=7d3e8ad6-f207-45e9-8375-8c55033f554e

[RaghavSood]

So the failure actually comes from nixosTests, not the build - but also intermittently - merging first, I will check out the tests soon

[RaghavSood]

Likely related to #294725 - would explain why it failed, then passed - subsequent runs probably had the test build from the previous round of linux tests available in the cache and could download and run it