Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-butler: init at 0.11.7 #311361

Closed
wants to merge 2 commits into from

Conversation

DataHearth
Copy link
Contributor

@DataHearth DataHearth commented May 13, 2024

Description of changes

  • Add git-butler application

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@DataHearth DataHearth requested a review from alyssais as a code owner May 13, 2024 13:19
@github-actions github-actions bot added the 6.topic: lib The Nixpkgs function library label May 13, 2024
@DataHearth
Copy link
Contributor Author

Result of nixpkgs-review pr 311361 run on x86_64-linux 1

1 package blacklisted:
  • nixos-install-tools
2 packages built:
  • git-butler
  • nix-init

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3927

@msanft
Copy link
Contributor

msanft commented May 14, 2024

As long as it works, I wouldn't object to merge this, but on the long term, it might be favorable to build from source, as tried in #289664

Given that the mentioned PR is open for a long time though, it might be a good short-term solution to package the AppImage

Copy link
Contributor

@msanft msanft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Title should be git-butler:...
Tested the package on x86-64 Linux, which works besides of some little UI bugs, which I believe to exist upstream as well. Will test the MacOS build once I get to my MacOS machine tonight

@DataHearth DataHearth changed the title gitbutler: init at 0.11.7 git-butler: init at 0.11.7 May 14, 2024
@msanft
Copy link
Contributor

msanft commented May 21, 2024

Result of nixpkgs-review pr 311361 run on aarch64-darwin 1

2 packages built:
  • git-butler
  • nix-init

@msanft
Copy link
Contributor

msanft commented May 21, 2024

Screenshot 2024-05-21 at 23 23 39 Other than the abve warning, which can be suppressed, the app seems to work fine under MacOS. Will give the diff another review tomorrow

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3974

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4017

@SuperSandro2000
Copy link
Member

As long as it works, I wouldn't object to merge this, but on the long term, it might be favorable to build from source, as tried in #289664

Since we already got a PR that builds it from source and with the recent addition of the pnpm builder, I don't see any blockers over there. Please pick that up instead and we can come back to this one, if that hits a wall.

@DataHearth DataHearth self-assigned this Sep 20, 2024
@DataHearth DataHearth deleted the add/app/gitbutler-0.11.5 branch September 21, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants