tiddit: init 3.6.1 #312995
tiddit: init 3.6.1 #312995
Conversation
|
Thanks for your review (and fast too). I've updated the PR accordingly. Please tell me if something is missing. |
|
@fabaff This PR should be ready to merge and your comment should have been addressed. If you could look at it, it would be nice :) |
apraga
force-pushed
the
tiddit
branch
2 times, most recently
from
16ed2e5
to
0644747
Compare
|
@fabaff Hi, I've rebased the change against master, removed useless arguments and applied nixfmt. Does that looks good to you ? Thanks |
|
Please check ofborg build failure below. If you don't have the device and there's no clue to fix them upstream (issues/prs), please mark these platforms as broken. |
pkgs/by-name/fe/fermi2/package.nix
Outdated
| mainProgram = "fermi2"; | ||
| license = licenses.mit; | ||
| maintainers = with maintainers; [ apraga ]; | ||
| platforms = platforms.unix; |
There was a problem hiding this comment.
I think this is only supported by x86-64 so that needs to be specified.
| platforms = platforms.unix; | |
| platforms = lib.intersectLists lib.platforms.x86_64 lib.platforms.unix; |
Tiddit dependency.
Tiddit dependency.
Genomic tool to call structural variations. This packages requires 2 executables,packaging fermi2, bwt2, that are packaged in the same derivation and added to the path later on.
There was a problem hiding this comment.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 312995
x86_64-darwin
✅ 4 packages built:
- fermi2
- ropebwt2
- tiddit
- tiddit.dist
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 312995
x86_64-linux
✅ 4 packages built:
- fermi2
- ropebwt2
- tiddit
- tiddit.dist
Genomic tool to call structural variations.
Description of changes
New package : a CLI tool written in python. It depends on 2 other executables, not packaged as a separate derivation.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.