Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vlc: 3.0.20 -> 3.0.21, add maintainer #319262

Merged
merged 2 commits into from
Jun 13, 2024
Merged

vlc: 3.0.20 -> 3.0.21, add maintainer #319262

merged 2 commits into from
Jun 13, 2024

Conversation

alois31
Copy link
Contributor

@alois31 alois31 commented Jun 12, 2024

Description of changes

Upstream changelog: https://code.videolan.org/videolan/vlc/-/blob/dd8bfdbabe8ae3974ca3864ad3125879f523e3a2/NEWS

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jun 12, 2024
@alois31
Copy link
Contributor Author

alois31 commented Jun 12, 2024

I will try to write an update script later so that r-ryantm works.

@ofborg ofborg bot requested a review from AndersonTorres June 12, 2024 09:50
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Jun 12, 2024
@AndersonTorres
Copy link
Member

AndersonTorres commented Jun 12, 2024 •
edited
Loading

  1. nix-update-script does not work?
  2. can't ryanbot catch this automatically? what's going on?

@SuperSandro2000
Copy link
Member

  • nix-update-script does not work?

I don't think it can find the version with fetchurl

@alois31
Copy link
Contributor Author

alois31 commented Jun 12, 2024

  1. nix-update-script does not work?

No: nix_update.errors.VersionError: Please specify the version. We can only get the latest version from codeberg/crates.io/gitea/github/gitlab/notabug/pypi/savannah/sourcehut/rubygems projects right now

2. can't ryanbot catch this automatically? what's going on?

fetchpatch: nix-community/nixpkgs-update#427

I think I will defer writing an update script until getting a response on that, since this issue probably affects quite a lot of packages.

@AndersonTorres
Copy link
Member

Oh, such flexibility...

@SuperSandro2000 SuperSandro2000 merged commit a0a523d into NixOS:master Jun 13, 2024
27 of 28 checks passed
@LeSuisse
Copy link
Contributor

Includes a security fix https://www.videolan.org/security/sb-vlc3021.html (VideoLAN-SB-VLC-3021).

@LeSuisse LeSuisse added 1.severity: security Issues which raise a security issue, or PRs that fix one backport release-23.11 backport release-24.05 Backport PR automatically labels Jun 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Backport failed for release-23.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-23.11
git worktree add -d .worktree/backport-319262-to-release-23.11 origin/release-23.11
cd .worktree/backport-319262-to-release-23.11
git switch --create backport-319262-to-release-23.11
git cherry-pick -x 62b3c73a4e0e9ddc92de1c165492fce00c5027c4 ae916af7bebac5481cc998980dc7e124572e4d33

2 similar comments
@github-actions GitHub Actions
Copy link
Contributor

Backport failed for release-23.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-23.11
git worktree add -d .worktree/backport-319262-to-release-23.11 origin/release-23.11
cd .worktree/backport-319262-to-release-23.11
git switch --create backport-319262-to-release-23.11
git cherry-pick -x 62b3c73a4e0e9ddc92de1c165492fce00c5027c4 ae916af7bebac5481cc998980dc7e124572e4d33

@github-actions GitHub Actions
Copy link
Contributor

Backport failed for release-23.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-23.11
git worktree add -d .worktree/backport-319262-to-release-23.11 origin/release-23.11
cd .worktree/backport-319262-to-release-23.11
git switch --create backport-319262-to-release-23.11
git cherry-pick -x 62b3c73a4e0e9ddc92de1c165492fce00c5027c4 ae916af7bebac5481cc998980dc7e124572e4d33

@github-actions github-actions bot mentioned this pull request Jun 15, 2024
Merged
1 task
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

@github-actions GitHub Actions
Copy link
Contributor

Git push to origin failed for release-24.05 with exitcode 1

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Git push to origin failed for release-24.05 with exitcode 1

LeSuisse added a commit to LeSuisse/nixpkgs that referenced this pull request Jun 15, 2024
@LeSuisse
vlc: 3.0.20 -> 3.0.21
7c12fa5 
Manual backport of NixOS#319262.

Upstream changelog: https://code.videolan.org/videolan/vlc/-/blob/dd8bfdbabe8ae3974ca3864ad3125879f523e3a2/NEWS

Fixes https://www.videolan.org/security/sb-vlc3021.html (VideoLAN-SB-VLC-3021).
@LeSuisse LeSuisse mentioned this pull request Jun 15, 2024
Merged
13 tasks
@alois31 alois31 mentioned this pull request Jun 16, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres AndersonTorres approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes backport release-24.05 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alois31 @AndersonTorres @SuperSandro2000 @LeSuisse