Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stardust-xr-server: init at 0.44.1 #324375

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Conversation

Pandapip1
Copy link
Contributor

Description of changes

Closes #299584

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Pandapip1 Pandapip1 force-pushed the init-stardustxr branch 5 times, most recently from fccf00e to 24b614d Compare July 3, 2024 20:18
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build fails

  CMake Warning at build/cpm/CPM_0.32.2.cmake:76 (message):
    CPM: Your project is using an unstable development version of CPM.cmake.
    Please update to a recent release if possible.  See
    https://github.com/cpm-cmake/CPM.cmake for details.
  Call Stack (most recent call first):
    cmake/CPM.cmake:21 (include)
    CMakeLists.txt:111 (include)


  CMake Warning:
    Manually-specified variables were not used by the project:

      CMAKE_ASM_COMPILER
      CMAKE_ASM_FLAGS


  In file included from /build/cargo-vendor-dir/stereokit-sys-2.5.6/StereoKit/StereoKitC/libraries/sk_gpu.cpp:2:
  /build/cargo-vendor-dir/stereokit-sys-2.5.6/StereoKit/StereoKitC/libraries/sk_gpu.h: In function 'bool skg_read_file(const char*, void**, size_t*)':
  /build/cargo-vendor-dir/stereokit-sys-2.5.6/StereoKit/StereoKitC/libraries/sk_gpu.h:4817:15: warning: ignoring return value of 'size_t fread(void*, size_t, size_t, FILE*)' declared with attribute 'warn_unused_result' [-Wunused-result]
   4817 |         fread (*out_data, *out_size, 1, fp);
        |         ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  /build/cargo-vendor-dir/stereokit-sys-2.5.6/StereoKit/StereoKitC/platforms/linux.cpp:10:10: fatal error: X11/extensions/Xfixes.h: No such file or directory
     10 | #include <X11/extensions/Xfixes.h>
        |          ^~~~~~~~~~~~~~~~~~~~~~~~~
  compilation terminated.
  make[2]: *** [CMakeFiles/StereoKitC.dir/build.make:860: CMakeFiles/StereoKitC.dir/StereoKitC/platforms/linux.cpp.o] Error 1
  make[2]: *** Waiting for unfinished jobs....
  make[1]: *** [CMakeFiles/Makefile2:83: CMakeFiles/StereoKitC.dir/all] Error 2
  make: *** [Makefile:136: all] Error 2
  thread 'main' panicked at /build/cargo-vendor-dir/cmake-0.1.50/src/lib.rs:1098:5:

  command did not execute successfully, got: exit status: 2

  build script failed, must exit now
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@Pandapip1
Copy link
Contributor Author

Welp, time to figure out why that is.

@Pandapip1
Copy link
Contributor Author

Fixed

@Aleksanaa
Copy link
Member

Please verify it still works.

@Pandapip1
Copy link
Contributor Author

I have re-tested and can confirm it still works.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2073

@Aleksanaa Aleksanaa merged commit d428295 into NixOS:master Nov 1, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: stardustxr-server
5 participants