python312Packages.mdformat-wikilink: init at 0.2.0 #331006
Conversation
|
@natsukium Not sure if I'm doing something wrong but |
|
I believe you wanted to mention @natsukium (deja vu?). The wonders of sharing a 6 letter prefix username 😂 |
|
@natsukium is there anything else I need to do to get this merged? |
|
@dotlambda pinging as you left feedback on my other PR. Is there anything else I need to do to get this merged? Apologies as I'm new to contributing. |
|
|
||
| nativeBuildInputs = [ | ||
| poetry-core | ||
| pytest-cov |
There was a problem hiding this comment.
| pytest-cov |
pytest-cov is a pytest-plugin for tests, so we don't need it in nativeBuildInputs.
Also, we don't want to measure coverage because we test for packaging correctness.
There was a problem hiding this comment.
Seeing that there might be an issue with this as reported by the ofborg build. Do you have any suggestions?
There was a problem hiding this comment.
Please remove --cov=... with substituteInPlace in postPatch.
MattKang
force-pushed
the
add-mdformat-wikilink
branch
from
e2f5572
to
e1fe05a
Compare
MattKang
force-pushed
the
add-mdformat-wikilink
branch
3 times, most recently
from
43f4e0b
to
552b79a
Compare
MattKang
force-pushed
the
add-mdformat-wikilink
branch
from
552b79a
to
62a60ff
Compare
Description of changes
Add
mdformat-wikilinkPython packageThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.