-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polonium: move to by-name, add HeitorAugustoLN to maintainers #333050
Conversation
70e5b54
to
d8a4a2e
Compare
d8a4a2e
to
aec5626
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package built:
The following issues got detected with the above build packages.
polonium:
got build log for '/nix/store/kv3sbcxgw7nhi9gdg53nig85rhcbw5z9-polonium-1.0rc' from 'https://cache.nixos.org' Near pkgs/by-name/po/polonium/package.nix:33:3:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md |
Is there any reason that you are building this with plasma5 and not plasma6? |
I didn't want to change the package build, and also there is no plasma-framework for plasma6 |
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.