Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polonium: move to by-name, add HeitorAugustoLN to maintainers #333050

Merged
merged 2 commits into from
Aug 11, 2024

Conversation

HeitorAugustoLN
Copy link
Member

Description of changes

  • Move polonium to by-name, since it doesn't work with Plasma 5 anymore
  • Add myself to one of polonium maintainers

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@gador gador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gador
Copy link
Member

gador commented Aug 11, 2024

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 333050 run on x86_64-linux 1

1 package built:
  • polonium

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

polonium:

got build log for '/nix/store/kv3sbcxgw7nhi9gdg53nig85rhcbw5z9-polonium-1.0rc' from 'https://cache.nixos.org'
When evaluating attribute ‘polonium’:
warning: attribute-typo
A likely typo in the dontNpmBuild argument was found, did you mean dontBuild?

Near pkgs/by-name/po/polonium/package.nix:33:3:

   |
33 |   dontNpmBuild = true;
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md

@gador gador merged commit 73fc02b into NixOS:master Aug 11, 2024
44 checks passed
@HeitorAugustoLN HeitorAugustoLN deleted the polonium branch August 11, 2024 13:27
@peterhoeg
Copy link
Member

Is there any reason that you are building this with plasma5 and not plasma6?

@HeitorAugustoLN
Copy link
Member Author

HeitorAugustoLN commented Aug 21, 2024

Is there any reason that you are building this with plasma5 and not plasma6?

I didn't want to change the package build, and also there is no plasma-framework for plasma6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants