Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ijq: 1.1.0 -> 1.1.1 #333783

Merged
merged 4 commits into from
Aug 11, 2024
Merged

ijq: 1.1.0 -> 1.1.1 #333783

merged 4 commits into from
Aug 11, 2024

Conversation

mattpolzin
Copy link
Contributor

@mattpolzin mattpolzin commented Aug 10, 2024

Description of changes

This PR includes a patch version bump, nix formatting, relocation to pkgs/by-name, and finally I'd like to volunteer to help maintain this package so I've added myself to the list of maintainers.

Version update changes: gpanders/ijq@v1.1.0...v1.1.1.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@mattpolzin

This comment was marked as outdated.

@mattpolzin

This comment was marked as outdated.

pkgs/by-name/ij/ijq/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ij/ijq/package.nix Outdated Show resolved Hide resolved
@mattpolzin
Copy link
Contributor Author

I addressed PR feedback in the same commit as I ran the formatter.

@mattpolzin
Copy link
Contributor Author

Result of nixpkgs-review run on x86_64-darwin 1

1 package built:
  • ijq

@mattpolzin
Copy link
Contributor Author

Result of nixpkgs-review pr 333783 run on x86_64-linux 1

1 package built:
  • ijq

@drupol drupol merged commit 770fe69 into NixOS:master Aug 11, 2024
9 of 10 checks passed
@mattpolzin mattpolzin deleted the ijq_1_1_1 branch August 11, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants