Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xcursor-pro: init at 2.0.2 #335188

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

xcursor-pro: init at 2.0.2 #335188

wants to merge 2 commits into from

Conversation

juuyokka
Copy link

Description of changes

XCursor Pro is modern, simple and elegant cursor theme.
https://github.com/ful1e5/XCursor-pro

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@midirhee12 midirhee12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM beside my personal nitpicks which I know will never change in nixpkgs

pkgs/by-name/xc/xcursor-pro/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/xc/xcursor-pro/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/xc/xcursor-pro/package.nix Show resolved Hide resolved
pkgs/by-name/xc/xcursor-pro/package.nix Outdated Show resolved Hide resolved
@juuyokka juuyokka marked this pull request as ready for review September 29, 2024 20:19
Copy link
Member

@midirhee12 midirhee12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the updateScript conventions. But other than that, this LGTM.

maintainers/maintainer-list.nix Show resolved Hide resolved
@ofborg ofborg bot requested a review from midirhee12 September 29, 2024 21:02
Copy link
Member

@midirhee12 midirhee12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides updateScript which I'm a bit unfamiliar with, this LGTM

Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a good idea to rename the package to xcursor-pro-theme to actually signify that it's a theme.

@@ -0,0 +1,36 @@
#!/usr/bin/env nix-shell
#! nix-shell -i bash -p nix-prefetch jq
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#! nix-shell -i bash -p nix-prefetch jq
#!nix-shell -i bash -p nix-prefetch jq

Small nitpick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants