-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xcursor-pro: init at 2.0.2 #335188
base: master
Are you sure you want to change the base?
xcursor-pro: init at 2.0.2 #335188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM beside my personal nitpicks which I know will never change in nixpkgs
31185d5
to
4ac1f4c
Compare
4ac1f4c
to
5d2d0fe
Compare
5d2d0fe
to
4807bfb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with the updateScript conventions. But other than that, this LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides updateScript
which I'm a bit unfamiliar with, this LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a good idea to rename the package to xcursor-pro-theme
to actually signify that it's a theme.
@@ -0,0 +1,36 @@ | |||
#!/usr/bin/env nix-shell | |||
#! nix-shell -i bash -p nix-prefetch jq |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#! nix-shell -i bash -p nix-prefetch jq | |
#!nix-shell -i bash -p nix-prefetch jq |
Small nitpick.
Description of changes
XCursor Pro is modern, simple and elegant cursor theme.
https://github.com/ful1e5/XCursor-pro
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.