Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.05] dbeaver-bin: fix crash at startup #335923

Closed

Conversation

mausch
Copy link
Member

@mausch mausch commented Aug 19, 2024

Fixes #330889

(cherry picked and adapted from commit da69826)

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Fixes NixOS#330889

(cherry picked and adapted from commit da69826)
@mkg20001
Copy link
Member

Result of nixpkgs-review pr 335923 run on x86_64-linux 1

1 package built:
  • dbeaver-bin

@mkg20001
Copy link
Member

Can you remove (cherry picked and adapted from commit https://github.com/mausch/nixpkgs/commit/da69826d745bdad0f2d9fc00830403387c6f3eb7) from commit description and prefix the commit message with [24.05] ?

CI doesn't like it otherwise

@gepbird
Copy link
Contributor

gepbird commented Sep 22, 2024

@mausch please fix the commit message for the failing CI check.

@gepbird
Copy link
Contributor

gepbird commented Sep 22, 2024

I just realized another dbeaver backport, #339947 also has this commit. I think its best to close this one, sorry.

@gepbird gepbird closed this Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants