-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[24.05] electron_31: init at 31.4.0, electron: bump default version to v31, element-desktop: use electron_31 #336018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teutat3s
changed the title
[24.05] electron_31: init at 31.4.0, electron: bump default version to v31
[24.05] electron_31: init at 31.4.0, electron: bump default version to v31, element-desktop: use electron_31
Aug 20, 2024
Co-authored-by: Yureka <yuka@yuka.dev> (cherry picked from commit 2e7a16d)
- Changelog: https://github.com/electron/electron/releases/tag/v31.0.0 - Diff: electron/electron@refs/tags/v31.0.0...v31.4.0 Co-authored-by: Yureka <yuka@yuka.dev> (cherry picked from commit f74c081)
- Changelog: https://github.com/electron/electron/releases/tag/v31.0.0 - Diff: electron/electron@refs/tags/v31.0.0...v31.4.0 Co-authored-by: Yureka <yuka@yuka.dev> (cherry picked from commit a057f76)
Last contributions were in 2018 and 2015. Update list to de-facto maintainers. (cherry picked from commit d5ccd64)
Upstream switched to electron 31 in version 1.11.70 element-hq/element-desktop@597f356 (cherry picked from commit 376b7ca)
(cherry picked from commit 6830a7f)
Co-authored-by: Yureka <yuka@yuka.dev> (cherry picked from commit 080e1c1)
teutat3s
force-pushed
the
backport-electron-31
branch
from
August 20, 2024 08:33
efe7ccf
to
9863623
Compare
Result of 1 package marked as broken and skipped:
52 packages built:
|
I think we can just merge this and monitor fallout? (unless anyone strongly objects) |
22 tasks
emilazy
approved these changes
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Manual backport of #333907 and #330323.
Bumps the default electron version to 31, because 29 is EOL today #335850.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.