Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-24.05] buildkite-agent: 3.59.0 -> 3.77.0 #336755

Merged
merged 4 commits into from
Aug 30, 2024
Merged

[release-24.05] buildkite-agent: 3.59.0 -> 3.77.0 #336755

merged 4 commits into from
Aug 30, 2024

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Aug 23, 2024

Description of changes

This contains the bumps of buildkite-agent to 3.77.0, without the workaround we temporarily introduced in 1295582, as that behaviour got reverted in 3.77.0.

It includes a fix for the occasionally occuring open /dev/pts/0: permission denied bug by upstream downgrading the pty library buildkite-agent was using (buildkite/agent#2790).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

zimbatm and others added 4 commits August 23, 2024 14:10
@zimbatm @flokli
buildkite-agent: move to by-name
e3fa245 
(cherry picked from commit 7d7fd84)
@flokli
buildkite-agent: 3.59.0 -> 3.76.1
e6a019c 
This does not include the workaround we included in nixos unstable, as
the behaviour is fixed with 3.77.0.

(cherry picked from commit 1295582)
@r-ryantm @flokli
buildkite-agent: 3.76.1 -> 3.76.2
5db2327 
(cherry picked from commit 9e3a379)
@flokli
buildkite-agent: 3.76.2 -> 3.77.0
e40e5d0 
(cherry picked from commit bccb2f7)
@flokli flokli changed the title buildkite-agent: 3.59.0 -> 3.77.0 [release-24.05] buildkite-agent: 3.59.0 -> 3.77.0 Aug 23, 2024
@flokli flokli merged commit 0e94df7 into NixOS:release-24.05 Aug 30, 2024
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flokli @techknowlogick @zimbatm @r-ryantm