Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lprobe: init at 0.1.3 #337174

Merged
merged 2 commits into from
Sep 5, 2024
Merged

lprobe: init at 0.1.3 #337174

merged 2 commits into from
Sep 5, 2024

Conversation

cageyv
Copy link
Contributor

@cageyv cageyv commented Aug 25, 2024

https://github.com/fivexl/lprobe/releases/tag/v0.1.3

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Screenshot 2024-08-25 at 13 25 11

Add a 👍 reaction to pull requests you find important.

@cageyv
Copy link
Contributor Author

cageyv commented Aug 28, 2024

@ofborg build

@cageyv
Copy link
Contributor Author

cageyv commented Aug 28, 2024

cc @wineee @vbgl @matteo-pacini
It works as expected. Screenshot attached.

Long story short. Docker Desktop Debug uses NixOS. Lprobe is my default tool for Health Checks inside containers.

Copy link
Contributor

@matteo-pacini matteo-pacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution, I just left a few comments.

Happy to help / elaborate further if requested changes are not clear 🙏🏻

maintainers/team-list.nix Outdated Show resolved Hide resolved
maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/tools/networking/lprobe/default.nix Outdated Show resolved Hide resolved
pkgs/by-name/lp/lprobe/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/lp/lprobe/package.nix Outdated Show resolved Hide resolved
@cageyv
Copy link
Contributor Author

cageyv commented Sep 1, 2024

@matteo-pacini

Thank you for your suggestions and guidelines. 🙏🏻

  • team removed
  • maintainer in separate commit
  • duplicate removed
  • platforms added
  • hash fixed

Copy link
Contributor

@matteo-pacini matteo-pacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing my comments

@wineee wineee merged commit 6d1448b into NixOS:master Sep 5, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants