-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lprobe: init at 0.1.3 #337174
lprobe: init at 0.1.3 #337174
Conversation
72c73c7
to
c8526f6
Compare
@ofborg build |
cc @wineee @vbgl @matteo-pacini Long story short. Docker Desktop Debug uses NixOS. Lprobe is my default tool for Health Checks inside containers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your first contribution, I just left a few comments.
Happy to help / elaborate further if requested changes are not clear 🙏🏻
Thank you for your suggestions and guidelines. 🙏🏻
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for addressing my comments
https://github.com/fivexl/lprobe/releases/tag/v0.1.3
Description of changes
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.