fragment-mono: init at 1.21

[noahgitsham]

Description of changes

Adds a new package for the Fragment Mono font.

It's already available in the google-fonts package, but nice to have it separated aswell (as seen in the roboto packages).

(This is my first nixpkgs PR, please let me know if I've made any mistakes)

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[noahgitsham]

@AndersonTorres Ah apologies forgot to rtfm on pkgs specifically, let me fix all this.

[noahgitsham]

Is there some OfBorg command someone/me has to run to get it to run/skip those two Darwin tests or is there just a long unskippable queue? This package has no passthru.tests which is what it says it's waiting to run.

[ryand56]

Is there some OfBorg command someone/me has to run to get it to run/skip those two Darwin tests or is there just a long unskippable queue? This package has no passthru.tests which is what it says it's waiting to run.

It's a long unskippable queue due to having less Darwin machines and the fact that Darwin is slow and not able to be emulated that well.

[AndersonTorres]

Squash the commits according to contributing guidelines.

[noahgitsham]

Squash the commits according to contributing guidelines.

What's wrong with the commits? Are the last two not covered by the etc in (pkg-name): (from -> to | init at version | refactor | etc)

[AndersonTorres]

A newly-added package does not need a commit for each fixup:

https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions

If you have commits pkg-name: oh, forgot to insert whitespace: squash commits in this case.
Use git rebase -i. See Squashing Commits for additional information.

Fixup the three last commits into one.

[noahgitsham]

A newly-added package does not need a commit for each fixup:

I see, could be clearer to write that explicitly in CONTRIBUTING.md, as I assumed oh, forgot to insert whitespace only meant formatting changes.

[AndersonTorres]

I see, could be clearer to write that explicitly in CONTRIBUTING.md, as I assumed oh, forgot to insert whitespace only meant formatting changes.

The idea behind this is more general, and a bit hard to express in words.
The idea is that small fixups - including but not limited to formatting - do not need an entry in the commit history.

Further, there is another unwritten rule: the first time a package is included in Nixpkgs, it should be included as if it was done perfectly.
Therefore, even big fixups like "add changelog link" or "add Python as dependency (thanks EggSpam for noticing this!)" should not appear in the commit history of a new package.

(Obviously there are exceptions, such as including a package that requires a modification in another existing package - but this is another story...)

[noahgitsham]

Don't mean to sound impatient, there's no rush, but I'm curious as to why this hasn't been merged yet.

Does each PR need multiple manual approvals? Or can I run the merge bot command to do it now?

[AndersonTorres]

Don't mean to sound impatient, there's no rush, but I'm curious as to why this hasn't been merged yet.

Because no human with the power to push the button pushed it yet.

Does each PR need multiple manual approvals?

No. It just needs a human with the power to push the button to push it.

Or can I run the merge bot command to do it now?

The merge bot will not push the button in this case.
I will not elaborate, but the merge bot merges only PRs that came from the auto-updater bot, and only in specific circumstances.

---

Summarizing, you need to find a human with the power to push the button.

There are some places you can find them:

• Discourse:
  • If no one has seen your PR, ask for a review here first: https://discourse.nixos.org/t/prs-ready-for-review/3032/
  • If your PR was reviewed, ask for merge here: https://discourse.nixos.org/t/prs-already-reviewed/2617
• Matrix: https://app.element.io/#/room/#review-requests:nixos.org
• Discourse (unofficial but a lot of people uses it): https://discord.gg/BqdJJFER4H
• Knock on their doors - I never tried this tbh since I am not in Europe.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1967

[noahgitsham]

Great, thanks for all the help! This feels like a very welcoming community.