-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
signalbackup-tools: 20240816 -> 20240830 #338253
Conversation
7f5a24b
to
1cfbe81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we switch to cmake?
1cfbe81
to
f21e413
Compare
@NickCao, didn't notice he added that. Good call. Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we drop postPatch
and installPhase
?
f21e413
to
a76f741
Compare
@NickCao, good catch regarding I'm no CMake expert, but pretty sure this package's CMake config doesn't contain any install instructions or whatever. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM, waiting for ofborg to build on darwin.
Result of 1 package built:
|
Description of changes
Upadate to latest version. Add new Darwin specific framework dependency and update to using
cmake
.Diff: bepaald/signalbackup-tools@2024081...2024083
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.