(deprecated) stardrop: init at 1.2.1

[jh-devv]

Description of changes

Stardrop is an open-source, cross-platform mod manager for the game Stardew Valley.
https://floogen.gitbook.io/stardrop/

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[jh-devv]

I have not yet pushed the changes but I have added an FHS environment to the package. This was recommended on the Matrix channel since it launches a game.

[SigmaSquadron]

I have not yet pushed the changes but I have added an FHS environment to the package. This was recommended on the Matrix channel since it launches a game.

I saw the FHS you posted on Matrix. My only nit with it is that you should avoid using the pname variable everywhere, and hardcode executable names instead. Overriding the pname shouldn't alter the final derivation.

[eclairevoyant]

Does this really not work without an FHS env? We're building the thing from source here, surely we can patch as needed

[eclairevoyant]

Also, please rebase and squash everything into the first commit

[jh-devv]

Also, please rebase and squash everything into the first commit

Yikes, didn't mean to do that, sorry!

[jh-devv]

Does this really not work without an FHS env? We're building the thing from source here, surely we can patch as needed

Haven't looked into the code but I suspect heavily it does not.

[eclairevoyant]

I suspect heavily it does not.

Please try. We really want to avoid FHS envs.

[jh-devv]

I suspect heavily it does not.

Please try. We really want to avoid FHS envs.

Oh, well, I'll take a look at the code of the application and the linking of the binary! 👍

[jh-devv]

Without FHS, the application works, you can't run the game though. I suspect this is because the game is linked against FHS paths.

❯ readelf -a Stardew\ Valley | grep "/" 

  OS/ABI:                            UNIX - GNU
      [Requesting program interpreter: /lib64/ld-linux-x86-64.so.2]
  Tag        Type                         Name/Value
 0x000000000000000f (RPATH)              Library rpath: [$ORIGIN/netcoredeps]

You can really patch the game, without the updates braking and stuff like that. Because of this, it cannot run in an non FHS environment without patching the game, which is not even in the slightest sense practical.

[eclairevoyant]

The FHS env is only going to apply to the application being built here, how is the game relevant?

[jh-devv]

The FHS env is only going to apply to the application being built here, how is the game relevant?

Because, it is an mod manager and a launcher for the game. You can click a button to launch the game.

[jh-devv]

You could launch it from steam (since, it just manages the mod files) and SMAPI (the mod loader) is already patched in. But then you lose functionality like better logs, priority mods etc.

[eclairevoyant]

and a launcher for the game.

This was not mentioned at all in the original description. Now this whole rigmarole makes sense.

[jh-devv]

and a launcher for the game.

This was not mentioned at all in the original description. Now this whole rigmarole makes sense.

Oh, yeah, sorry.... but yeah... You don't have to use it as a launcher, but you can. I for example, don't.

[poperigby]

Anything else need to be done to get this merged?

[jh-devv]

Silly me :3 Accidentally deleted the branch lol, it's back up now!

[jh-devv]

Some problems with the fork, i'll get it back this evening!