[Backport release-24.05] go: Backport go 1.23 to nixos-24.05

[mglazer]

Description of changes

go 1.23 is the latest go version.

1.21 has already lost support: https://go.dev/doc/devel/release, this at least gives us some level of ability to take 1.23 and ensure our containers are built with the same go version.

Cherry-picked from: cf4f89e

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[eclairevoyant]

Please follow the guidelines here for backporting:
https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#how-to-backport-pull-requests

particularly cherry-picking, the branch to target, and ensuring that stable doesn't have breakage before backporting

[mglazer]

Thanks. Missed a few details there.

One thing, there is no single commit that I can pick to cherry pick. I'm backporting the entire package definition.

[winterqt]

Please cherry-pick "properly," instead of adding your own commit message/comments/etc.

[eclairevoyant]

One thing, there is no single commit that I can pick to cherry pick.

Then you may need to cherry-pick multiple commits. That's fine, but creating an entirely new commit on the release-* branch isn't.

[mglazer]

OK, backported everything except for the merge commits.

There was a single merge conflict with: d82203f which I resolved the best I could.

[mglazer]

Is this the right way? It just seemed questionable to backport changes which bring in other unrelated changes.

[mglazer]

The reason this is failing the cherrypick, is platforms.wasi was added here:

050df1a

which is before go1.23 existed. I opted to not add additional functionality that wasn't part of the strict set of cherrypicks when resolving the merge conflict. Happy to add platforms.wasi to go1.22 if that's desired.

[Scrumplex]

Do we have a chance to get this backported without rebuilding so many packages? #344149 needs a backport for a critical vulnerability where upstream already updated to Go 1.23.

[mweinelt]

Ideally we will not backport the whole version bump, but just the patch for traefik.