-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport release-24.05] Backport 339264 to release 24.05 #340037
[Backport release-24.05] Backport 339264 to release 24.05 #340037
Conversation
EOL at 2024-06-28
https://github.com/k3s-io/k3s/releases/tag/v1.28.13%2Bk3s1 (cherry picked from commit 941e3cc)
https://github.com/k3s-io/k3s/releases/tag/v1.29.8%2Bk3s1 (cherry picked from commit 864f4c2)
https://github.com/k3s-io/k3s/releases/tag/v1.30.4%2Bk3s1 (cherry picked from commit de4b0a0)
Release: https://github.com/k3s-io/k3s/releases/tag/v1.31.0%2Bk3s1 (cherry picked from commit d3da752)
The cherry picks checker fails probably because I made some manual changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of nixpkgs-review pr 340037
run on x86_64-linux 1
4 packages built:
- k3s (k3s_1_30)
- k3s_1_28
- k3s_1_29
- k3s_1_31
Cherry-pick check is failing: https://github.com/NixOS/nixpkgs/actions/runs/10736215337/job/29775134085?pr=340037 |
Thank you for the call-out, in this case it would be expected to fail as the PRs commits will not match exactly. We are not going to be migrating the |
Description of changes
Backport #339264 to release 24.05.
k3s_1_27: remove
k3s_1_28: 1.28.12+k3s1 -> 1.28.13+k3s1
k3s_1_29: 1.29.7+k3s2 -> 1.29.8+k3s1
k3s_1_30: 1.30.3+k3s1 -> 1.30.4+k3s1
k3s_1_31: init 1.31.0+k3s1
I removed 1.27 as it's EOL and I guess 24.05 shouldn't provide EOL packages (it's not only EOL but also not the newest patch version). Let me know if 1.27 was on purpose still in 24.05.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)@NixOS/k3s
Add a 👍 reaction to pull requests you find important.