Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fonts: Update gdouros fonts to use Web Archive (temporary fix) #340159

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

Ate329
Copy link
Contributor

@Ate329 Ate329 commented Sep 6, 2024

Description of changes

This PR fixes issue #339757

The original website (https://dn-works.com) hosting the gdouros fonts is currently down. This PR updates the URLs to use Web Archive versions as a temporary solution.

Changes:

  • Updated all URLs in pkgs/data/fonts/gdouros/default.nix to use Web Archive links
  • Updated the src attribute in the mkpkg function to use the Web Archive URL
  • Updated the homepage meta field to point to the Web Archive version of the original site

This is a temporary fix to ensure the fonts remain accessible while the original website is unavailable. We should revert these changes once the original site is back online.

Steps taken:

  1. Replaced all download URLs with their Web Archive counterparts
  2. Updated the src attribute to fetch from Web Archive
  3. Verified that all fonts can be downloaded and built successfully
  4. Updated the homepage in the meta attribute to reflect the Web Archive URL

Testing:

  • Built several fonts individually using nix-build -A <font-name>
  • Confirmed that the build process is working properly for the tested fonts
  • Installed and tested some of the fonts to ensure they work correctly

Tested fonts:

  • aegyptus
  • akkadian
  • symbola

All tested fonts built successfully and are functioning as expected.

Note: This is not an ideal long-term solution, as Web Archive links may not be as stable as the original source. We should monitor the situation and update the package once the original website is restored.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@mkg20001
Copy link
Member

mkg20001 commented Sep 9, 2024

Result of nixpkgs-review pr 340159 run on x86_64-linux 1

@mkg20001
Copy link
Member

mkg20001 commented Sep 9, 2024

Force pushed to fix commit message, rebased to drop merge commit

@mkg20001
Copy link
Member

mkg20001 commented Sep 9, 2024

Result of nixpkgs-review pr 340159 run on x86_64-linux 1

@mkg20001 mkg20001 merged commit 319e983 into NixOS:master Sep 9, 2024
21 checks passed
@mkg20001 mkg20001 added the backport release-24.05 Backport PR automatically label Sep 9, 2024
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants