jinja-lsp: init at 0.1.81 #341074
Open
jinja-lsp: init at 0.1.81 #341074
+34
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FliegendeWurst
suggested changes
Oct 30, 2024
|
|
||
| cargoHash = "sha256-vMoDbUDImDp+DPjS0rfJD9hYUa79bKsDUyAhAZvEyxA="; | ||
|
|
||
| meta = with lib; { |
There was a problem hiding this comment.
Suggested change
| meta = with lib; { | |
| meta = { |
Comment on lines
+22
to
+23
| license = licenses.mit; | ||
| maintainers = with maintainers; [ lytedev ]; |
There was a problem hiding this comment.
Suggested change
| license = licenses.mit; | |
| maintainers = with maintainers; [ lytedev ]; | |
| license = lib.licenses.mit; | |
| maintainers = with lib.maintainers; [ lytedev ]; |
| github = "lytedev"; | ||
| githubId = 508402; | ||
| name = "Daniel Flanagan"; | ||
| keys = [ { fingerprint = "823E B345 6C62 D193 8904 2027 5B20 20A0 F992 1EF4"; } ]; |
There was a problem hiding this comment.
Only needed if you sign your git commits.
Co-authored-by: Arne Keller <2012gdwu+github@posteo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.
Sorry I hugely goofed up the previous PR and alerted a bunch of folks and lost the previous review context 😢. #338003