Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-24.05] gitlab: 17.2.4 -> 17.2.5 #341502

Merged
merged 2 commits into from
Sep 17, 2024
Merged

[Backport release-24.05] gitlab: 17.2.4 -> 17.2.5 #341502

merged 2 commits into from
Sep 17, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 13, 2024 •
edited by yayayayaka
Loading

Bot-based backport to release-24.05, triggered by a label in #341398.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@github-actions github-actions bot mentioned this pull request Sep 13, 2024
Merged
13 tasks
cafkafk
cafkafk requested changes Sep 13, 2024
View reviewed changes
Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failing tests should probably be addressed first before merge

@risicle
Copy link
Contributor

risicle commented Sep 15, 2024

passthru.tests successful for me, nixos x86_64.

@cafkafk
Copy link
Member

cafkafk commented Sep 15, 2024

@ofborg build gitlab gitlab-container-registry gitlab.passthru.tests gitlab-container-registry.passthru.tests

cafkafk
cafkafk approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guess it just works now? ¯\(ツ)/¯

@cafkafk cafkafk merged commit fda9a0a into release-24.05 Sep 17, 2024
21 of 22 checks passed
@cafkafk cafkafk deleted the backport-341398-to-release-24.05 branch September 17, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cafkafk cafkafk cafkafk approved these changes

@Conni2461 Conni2461 Awaiting requested review from Conni2461

@talyz talyz Awaiting requested review from talyz

@yayayayaka yayayayaka Awaiting requested review from yayayayaka

@dasJ dasJ Awaiting requested review from dasJ

@krav krav Awaiting requested review from krav

@xanderio xanderio Awaiting requested review from xanderio

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@risicle @cafkafk @yayayayaka