Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moq-relay: init at v0.6.2 #342442

Closed

Conversation

therishidesai
Copy link
Contributor

@therishidesai therishidesai commented Sep 17, 2024

Description of changes

Create nixos module for moq-relay. moq-relay package comes from #342588

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@s0me1newithhand7s
Copy link
Contributor

pls, try to not ping 3500+ ppls this time. 💀

@hraban
Copy link
Member

hraban commented Sep 17, 2024

pls, try to not ping 3500+ ppls this time. 💀

🤷 as one of the people getting pinged, at what point do we take responsibility for the fragility of this system? do we truly expect nobody to ever make the mistake of merging off staging and accidentally creating a PR into the default base branch offered by GH (master)? 😛 I know I've been there.

thanks for the contribution @therishidesai :)

@purrpurrn
Copy link
Contributor

Perfect for gorgeous looks, can push asap @‌NixOS/‌nix‌pkgs‌-com‌mitters @‌Nix‌OS/nixpkgs-maintainers @‌Nix‌OS/n‌ixpkgs-v‌et‌

@therishidesai
Copy link
Contributor Author

pls, try to not ping 3500+ ppls this time. 💀

Sorry about that

@nyabinary
Copy link
Contributor

Can't you just have one PR and init the package in one commit and init the module in the other 2 commits?

Copy link
Contributor

@nyabinary nyabinary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC this isn't required for packages in by-name.

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@nyabinary nyabinary mentioned this pull request Sep 17, 2024
13 tasks
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message should be moq-relay: init at 0.6.0.
Please add some hardening to the service.

pkgs/by-name/mo/moq-relay/package.nix Outdated Show resolved Hide resolved
nixos/modules/services/video/moq-relay.nix Outdated Show resolved Hide resolved
@therishidesai
Copy link
Contributor Author

Can't you just have one PR and init the package in one commit and init the module in the other 2 commits?

Was just basing this off of other packages where the package was added in an init PR and the nixos module was in another PR

@therishidesai
Copy link
Contributor Author

Commit message should be moq-relay: init at 0.6.0. Please add some hardening to the service.

I had a separate PR to just add the moq-relay package. Is it fine that this PR has 2 commits? In the past I remember maintainers asking for single atomic commits in the PR

@therishidesai
Copy link
Contributor Author

Please add some hardening to the service.

I'm not too familiar with the systemd hardening. Are there any services I should look at for hardening examples? What specifically makes sense for this server?

@dotlambda
Copy link
Member

dotlambda commented Sep 19, 2024

Are there any services I should look at for hardening examples?

Just grep for "hardening" in nixos/. Also see https://www.freedesktop.org/software/systemd/man/latest/systemd.exec.html.

@therishidesai therishidesai changed the title nixos/moq-relay: init moq-relay systemd service moq-relay: init at v0.6.0 Sep 23, 2024
@therishidesai
Copy link
Contributor Author

Are there any services I should look at for hardening examples?

Just grep for "hardening" in nixos/. Also see https://www.freedesktop.org/software/systemd/man/latest/systemd.exec.html.

Added some new hardening and cleaned up users/groups similar to other server modules in nixos.

@therishidesai therishidesai force-pushed the rdesai/moq-relay-service branch 3 times, most recently from b437ead to c5b8c35 Compare September 24, 2024 15:43
@therishidesai therishidesai changed the title moq-relay: init at v0.6.0 moq-relay: init at v0.6.2 Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants