-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moq-relay: init at v0.6.2 #342442
moq-relay: init at v0.6.2 #342442
Conversation
1ecbb1c
to
c3d6ba9
Compare
pls, try to not ping 3500+ ppls this time. 💀 |
🤷 as one of the people getting pinged, at what point do we take responsibility for the fragility of this system? do we truly expect nobody to ever make the mistake of merging off staging and accidentally creating a PR into the default base branch offered by GH (master)? 😛 I know I've been there. thanks for the contribution @therishidesai :) |
Perfect for gorgeous looks, can push asap @NixOS/nixpkgs-committers @NixOS/nixpkgs-maintainers @NixOS/nixpkgs-vet |
Sorry about that |
Can't you just have one PR and init the package in one commit and init the module in the other 2 commits? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC this isn't required for packages in by-name
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message should be moq-relay: init at 0.6.0
.
Please add some hardening to the service.
Was just basing this off of other packages where the package was added in an init PR and the nixos module was in another PR |
I had a separate PR to just add the |
c3d6ba9
to
76fbcd5
Compare
I'm not too familiar with the systemd hardening. Are there any services I should look at for hardening examples? What specifically makes sense for this server? |
Just grep for "hardening" in |
76fbcd5
to
bb09692
Compare
Added some new hardening and cleaned up users/groups similar to other server modules in nixos. |
b437ead
to
c5b8c35
Compare
c5b8c35
to
9df4c9b
Compare
9df4c9b
to
5ba7909
Compare
Description of changes
Create nixos module for moq-relay. moq-relay package comes from #342588
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.