Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webkitgtk: 2.44.3 → 2.46.0 #342812

Merged
merged 2 commits into from
Sep 27, 2024
Merged

webkitgtk: 2.44.3 → 2.46.0 #342812

merged 2 commits into from
Sep 27, 2024

Conversation

bobby285271
Copy link
Member

@bobby285271 bobby285271 commented Sep 18, 2024 •
edited
Loading

https://github.com/WebKit/WebKit/blob/webkitgtk-2.46.0/Source/WebKit/gtk/NEWS
https://github.com/WebKit/WebKit/commits/webkitgtk-2.46.0/Source/cmake

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from hedning, dasj19 and jtojnar September 18, 2024 15:28
@bobby285271 bobby285271 marked this pull request as ready for review September 20, 2024 13:43
@bobby285271
webkitgtk: 2.44.3 → 2.46.0
f968afe 
https://github.com/WebKit/WebKit/blob/webkitgtk-2.46.0/Source/WebKit/gtk/NEWS
https://github.com/WebKit/WebKit/commits/webkitgtk-2.46.0/Source/cmake

Explicitly add cairo, fontconfig and freetype.
@bobby285271
webkitgtk: Enable hyphen again
093f67c 
This is enabled in mostly all distros and from what I saw when this
option is disabled hyphen is not packaged yet.

ref: b82874e
ref: 86a7609
jtojnar
jtojnar approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEWS and diff look good to me.

@bobby285271 bobby285271 merged commit f65d89a into NixOS:master Sep 27, 2024
27 of 28 checks passed
@bobby285271 bobby285271 deleted the upd/webkitgtk branch September 27, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@hedning hedning Awaiting requested review from hedning

@dasj19 dasj19 Awaiting requested review from dasj19

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 11.by: package-maintainer 12.approvals: 1 12.approved-by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bobby285271 @jtojnar @wegank