Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ezminc: unstable-2019-03-12 -> unstable-2023-10-06; unbreak #342963

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

bcdarwin
Copy link
Member

Description of changes

Routine update; minor refactor and apply nixfmt; patch some script interpreter paths.

Package was previously broken since removal of ITK 4 due to ITK 5.x incompatibility. One cmake module (for diffeomorphic demons) had to be disabled since this code is still not working due to cmake conflicts and ITK 5 and recent gcc issues.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pbsbot
Copy link

pbsbot commented Oct 1, 2024

Result of nixpkgs-review pr 342963 run on x86_64-linux 1

1 package built:
  • ezminc

@bcdarwin bcdarwin requested a review from pbsds October 1, 2024 01:03
@pbsds pbsds merged commit c1d784a into NixOS:master Oct 1, 2024
26 checks passed
@bcdarwin bcdarwin deleted the unbreak-ezminc branch October 2, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants