electron_32: init at 32.1.1, bitwarden-desktop: 2024.8.2 -> 2024.9.0 #343097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotlambda
changed the title
ofborg
bot
added
8.has: package (new)
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
ofborg
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
and removed
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
amarshall
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Built and tested bitwarden-desktop (after rebasing this onto latest nixos-unstable branch). This included building electron_32 from source successfully on x86_64-linux.
While the other changes look good, my approval should probably not be seen as “enough” for them.
Note also that electron-chromedriver update got merged in #341973.
Not the update to 32.1.1. |
This comment was marked as outdated.
This comment was marked as outdated.
|
Result of 2 packages marked as broken and skipped:
2 packages failed to build:
109 packages built:
|
yayayayaka
approved these changes
Sep 23, 2024
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-343097-to-release-24.05 origin/release-24.05
cd .worktree/backport-343097-to-release-24.05
git switch --create backport-343097-to-release-24.05
git cherry-pick -x 90effb99edf82b41a082c3cf6e8726585f4b59c6 483e68aa6c6ad60b8ee283dac8eb3252ed2325a4 9e4edca155dbc29551f46bb6ebccc3948999753d b075f7d893fcc0c05a80714354598067ff6ccd13 bac1f69114aace9b58a5eeb68c15ba9c7f1ae575 f01b67406414907f2c95cd132003ae46590c757c |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Diff: bitwarden/clients@desktop-v2024.8.2...desktop-v2024.9.0
Changelog: https://github.com/bitwarden/clients/releases/tag/desktop-v2024.9.0
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.