Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.05] famistudio: 4.2.0 -> 4.2.1 #344255

Draft
wants to merge 1 commit into
base: release-24.05
Choose a base branch
from

Conversation

llakala
Copy link
Contributor

@llakala llakala commented Sep 24, 2024

(cherry picked from commit bfb185e)

Description of changes

This PR aims to backport the fix to Famistudio, so it doesn't just output this every tine it's run:

Error : Error initializing GLFW.

However, after cherry-picking the commit, it still produces the same error on my branch, while it runs perfectly fine on master. Maybe I'm missing something here.

Things done

  • Built on platform(s)
    • x86_64-linux (tried to, but it still wasn't working)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

(cherry picked from commit bfb185e)
@OPNA2608 OPNA2608 changed the title famistudio: 4.2.0 -> 4.2.1 [Backport release-24.05] famistudio: 4.2.0 -> 4.2.1 Sep 24, 2024
@ofborg ofborg bot requested a review from OPNA2608 September 24, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants