Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sview: init at 20_08 #344922

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

sview: init at 20_08 #344922

wants to merge 6 commits into from

Conversation

Mx2uller
Copy link
Contributor

Description of changes

Cross-platform solution to view 3D stereoscopic videos and images.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

pkgs/by-name/sv/sview/package.nix Outdated Show resolved Hide resolved
];
};

installPhase = ''

This comment was marked as resolved.

Comment on lines +36 to +40
ffmpeg_4
gtk2
libconfig
libGL
libXpm

This comment was marked as resolved.

];
maintainers = with maintainers; [ mx2uller ];
mainProgram = "sview";
platforms = platforms.linux;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supposedly it also works on Mac and Windows. It is okay to leave it as is if you can't test those platforms

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test on windows or mac, so I only included linux.

pkgs/by-name/sv/sview/package.nix Outdated Show resolved Hide resolved
Copy link
Contributor Author

@Mx2uller Mx2uller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I made changes like you suggested. Initially I did have buildInputs but tried to build package without it, and it built successfully and run. For some reason everything in nativeBuildInputs stays alive in nix store, even after gc.

maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
pkgs/by-name/sv/sview/package.nix Outdated Show resolved Hide resolved
Mx2uller and others added 2 commits October 27, 2024 17:24
Co-authored-by: Arne Keller <2012gdwu+github@posteo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants