Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pagefind: 1.1.0 -> 1.1.1 #344950

Merged
merged 2 commits into from
Oct 1, 2024
Merged

pagefind: 1.1.0 -> 1.1.1 #344950

merged 2 commits into from
Oct 1, 2024

Conversation

pbsds
Copy link
Member

@pbsds pbsds commented Sep 27, 2024

This has got to be one of the more cursed vendorings I've done recently. I exhausted every other option.

Diff: CloudCannon/pagefind@v1.1.0...v1.1.1
Release: https://github.com/CloudCannon/pagefind/releases/tag/v1.1.1
Changelog: https://github.com/CloudCannon/pagefind/blob/v1.1.1/CHANGELOG.md

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pbsds pbsds force-pushed the bump-pagefind-1725329421 branch 4 times, most recently from 6f78ae6 to 0d9d804 Compare September 27, 2024 21:31
@pbsds pbsds marked this pull request as ready for review September 27, 2024 21:32
@pbsds
Copy link
Member Author

pbsds commented Sep 27, 2024

you can test it with

nix shell github:nixos/nixpkgs/refs/pull/344950/merge#pagefind

Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
Co-authored-by: pbsds <pbsds@hotmail.com>
@pbsds
Copy link
Member Author

pbsds commented Sep 30, 2024

I rebased, reworded and adapted your commit.

Copy link
Member

@phanirithvij phanirithvij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-community/noogle locally, LGTM

@h7x4 h7x4 merged commit cc02f25 into NixOS:master Oct 1, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants